Skip to content

revist all ExponentialBackOff.NextBackOff usage #40626

@hzxuzhonghu

Description

@hzxuzhonghu

(This is used to request new product features, please visit https://discuss.istio.io for questions on using Istio)

Describe the feature request

As @howardjohn pointed, and I confirmed. By default ExponentialBackOff.NextBackOff will return -1, then we use it as delay for time.Sleep(), the function will return immediately, this is very bad the process can fall in dead loop.

Describe alternatives you've considered

Istio may need to wrap ExponentialBackOff to prevent such behavior.

Affected product area (please put an X in all that apply)

[ ] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Extensions and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

Affected features (please put an X in all that apply)

[ ] Multi Cluster
[ ] Virtual Machine
[ ] Multi Control Plane

Additional context

Metadata

Metadata

Assignees

No one assigned

    Labels

    kind/enhancementlifecycle/staleIndicates a PR or issue hasn't been manipulated by an Istio team member for a while

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions