-
Notifications
You must be signed in to change notification settings - Fork 8k
Closed
Labels
Description
This is primarily documentation for the bugs fixed in a PR.
There are two sets of issues:
-
Wildcard domains: we cannot match
*.com:*
, so we make the port explicit (*.com:80
). If a user users an unexpected port for the Host, we will not match. We only put one port -
More complex -- we have two route configs. One has wildcard and one doesn't:
- domains: [*.example.com:443] # match wildcard
- domains: [foo.example.com, foo.example.com:*] # match concrete
If a user sends foo.example.com:443
it would match the first one; we want the latter.