Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

add pdb for sidecar_injector. #138

Merged
merged 2 commits into from
May 9, 2019
Merged

add pdb for sidecar_injector. #138

merged 2 commits into from
May 9, 2019

Conversation

morvencao
Copy link
Member

howardjohn
howardjohn approved these changes May 9, 2019
View reviewed changes
istio-control/istio-autoinject/templates/poddisruptionbudget.yaml Outdated
release: {{ .Release.Name }}
istio: sidecar-injector
spec:
{{- if .Values.global.defaultPodDisruptionBudget.enabled }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This if is redundant from line 1 I think

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@morvencao morvencao force-pushed the br_pdb_for_sidecar_injector branch from 97e7767 to 2ad840c Compare May 9, 2019 04:49
@mergify mergify bot merged commit 3ed10b4 into istio:master May 9, 2019
@morvencao morvencao deleted the br_pdb_for_sidecar_injector branch May 9, 2019 05:04
@howardjohn howardjohn mentioned this pull request May 17, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@costinm costinm Awaiting requested review from costinm

@linsun linsun Awaiting requested review from linsun

@sdake sdake Awaiting requested review from sdake

1 more reviewer

@howardjohn howardjohn howardjohn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PDB to injector
2 participants
@morvencao @howardjohn