add nodeSelector and toleration. #170
Conversation
|
The change looks good, and we definitely need some of the fixes that got added here. My concern is that Kustomize is the perfect solution for toleration, affinity etc. We already support affinty so we should probably keep that, but do we want to add more (fairly complicated) fields that can be instead replaced by Kustomize? Given we already have affinity maybe it makes sense to get toleration as well (as in: we should have toleration+affinity or neither, not one or the other). |
global.yaml
Outdated
| @@ -251,6 +251,12 @@ global: | |||
| # the desired values. | |||
| defaultNodeSelector: {} | |||
|
|
|||
| # Default node tolerations to be applied to all deployments so that all pods can be | |||
There was a problem hiding this comment.
I don't think this makes any sense with the new installer - each component is installed independently, and it would have different settings. We also want to move this kind of 'global override' to kustomize and reduce API surface in values.yaml
There was a problem hiding this comment.
remove global default value.
There was a problem hiding this comment.
I would remove the 'default' from global to simplify. Unless there is a case where all components in Istio would need the same value.
We already have issues with the default CPU allocation - which is not right for any component, let's avoid repeating mistakes.
|
Looks good otherwise. |
|
Can we get this merged? Since it also contains quite a few some bugs about template. |
For
nodeSelectorandtoleration, define default values in global section to be applied to all deployments/daemonsets so that all pods can be scheduled to a particular nodes. Each component can overwrite these default values by adding its own block in the relevant section below and setting the desired values.