Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

fix(dashboards): ensure irate used for success rate calc #166

Merged
merged 1 commit into from
May 13, 2019
Merged

fix(dashboards): ensure irate used for success rate calc #166

merged 1 commit into from
May 13, 2019

Conversation

douglas-reid
Copy link
Contributor

Use irate in the denominator to match use in numerator in the service and workload dashboards.

Fixes: istio/istio#13626

@douglas-reid douglas-reid requested a review from mandarjog May 13, 2019 18:24
@mergify mergify bot merged commit fbe950e into istio:master May 13, 2019
@douglas-reid douglas-reid mentioned this pull request May 13, 2019
Closed
@howardjohn howardjohn mentioned this pull request May 17, 2019
Merged
@douglas-reid douglas-reid mentioned this pull request Jun 3, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mandarjog mandarjog Awaiting requested review from mandarjog

@costinm costinm Awaiting requested review from costinm

@linsun linsun Awaiting requested review from linsun

@sdake sdake Awaiting requested review from sdake

1 more reviewer

@howardjohn howardjohn howardjohn approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect service grafana dashboard with traffic split
2 participants
@douglas-reid @howardjohn