Skip to content

Add missing WASM/WAT files. #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 9, 2019
Merged

Add missing WASM/WAT files. #38

merged 1 commit into from
Mar 9, 2019

Conversation

jplevyak
Copy link

@jplevyak jplevyak commented Mar 7, 2019

Add missing WASM/WAT files.

@istio-testing
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jplevyak jplevyak requested a review from PiotrSikora March 7, 2019 22:34
@PiotrSikora
Copy link

Aren't we deprecating WAT files?

@jplevyak
Copy link
Author

jplevyak commented Mar 8, 2019

Yes, but I find them useful for debugging. How about we remove the .wat loading test in the V8 PR but leave the files themselves until after the Emscripten and V8 support is done.

PiotrSikora
PiotrSikora approved these changes Mar 8, 2019
View reviewed changes
Copy link

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry, I was under the impression that you wanted to remove them. I'm fine either way.

@jplevyak jplevyak merged commit 7cafa2a into istio:wasm Mar 9, 2019
@jplevyak
Copy link
Author

jplevyak commented Mar 9, 2019

Changed my mind while debugging the WASM protobuf support. Thanx

@jplevyak jplevyak deleted the wasm-files branch March 9, 2019 01:27
rlenglet pushed a commit that referenced this pull request Aug 13, 2019
@PiotrSikora
build: update v8 to 7.5.288.22 and migrate to wee8. (#38)
e5fb997 
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
brian-avery pushed a commit that referenced this pull request Jun 30, 2020
@jplevyak
Merge pull request #38 from istio-private/backport-1.4
dece5fd 
Backport 1.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@PiotrSikora PiotrSikora PiotrSikora approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jplevyak @istio-testing @PiotrSikora