Skip to content

Conversation

lambdai
Copy link

@lambdai lambdai commented Mar 11, 2021

For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md

Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
[Optional Fixes #Issue]
[Optional Deprecated:]

Shikugawa and others added 12 commits December 3, 2020 09:45
Fixing a bug where HTTP parser offsets for IPv6 hosts did not include [] and Envoy assumed it did.
This results in mis-parsing addresses for IPv6 CONNECT requests and IPv6 hosts in fully URLs over HTTP/1.1

Risk Level: low
Testing: new unit, integration tests
Docs Changes: n/a
Release Notes: inline
Signed-off-by: Shikugawa <rei@tetrate.io>
Co-authored-by: alyssawilk <alyssar@chromium.org>
…roxy#14066) (envoyproxy#14279)

Commit Message: Allow supervisord to open its log file
Additional Description:
Change the default location of the log file and give supervisord
permissions to write to it.

Risk Level: low
Testing: built image locally
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a

Signed-off-by: Alex Konradi <akonradi@google.com>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
… is marked dead by Lua GC (envoyproxy#14092) (envoyproxy#14449)

Co-authored-by: Marcin Falkowski <marcin.falkowski@allegro.pl>
… event. (envoyproxy#13858) (envoyproxy#14452)

Fixes envoyproxy#13856.

This change also contains the following backports:
- build: Fix some unused variable warnings (envoyproxy#13987)
- test: Check in all TLS test certs (envoyproxy#13702)

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
…4456)

Additional Description: Based on envoyproxy#14388
Risk Level: Low
Testing: Build and run the repro from envoyproxy#14119 without crashing, `bazel test test/extensions/clusters/aggregate:cluster_test`
Docs Changes: N/A
Release Notes:
envoyproxy#14119

Signed-off-by: Taylor Barrella <tabarr@google.com>
* ci: fix docs tag build

Signed-off-by: Lizan Zhou <lizan@tetrate.io>

* review

Signed-off-by: Shikugawa <rei@tetrate.io>

* add versionversion

Signed-off-by: Shikugawa <rei@tetrate.io>

* add versionversion

Signed-off-by: Shikugawa <rei@tetrate.io>

* add versionversion

Signed-off-by: Shikugawa <rei@tetrate.io>

* add versionversion

Signed-off-by: Shikugawa <rei@tetrate.io>

* master -> main

Signed-off-by: Shikugawa <rei@tetrate.io>

* fix

Signed-off-by: Shikugawa <rei@tetrate.io>

* ci: fix CodeQL-build by removing deprecated set-env command (envoyproxy#14046)

Signed-off-by: Taylor Barrella <tabarr@google.com>
Signed-off-by: Shikugawa <rei@tetrate.io>

* deps: Add more SHAs to configs and kafka requirements.txt (envoyproxy#14887)

Signed-off-by: Dhi Aurrahman <dio@rockybars.com>
Signed-off-by: Shikugawa <rei@tetrate.io>

Co-authored-by: Lizan Zhou <lizan@tetrate.io>
Co-authored-by: Taylor Barrella <tabarr@google.com>
Co-authored-by: Dhi Aurrahman <dio@rockybars.com>
…g timer fire (envoyproxy#14799) (envoyproxy#15007)

Fix a potential use-after-free error in ScaledRangeTimerManagerImpl by adding a processing_timers_ flag to the timer queues that is set during onQueueTimerFired processing. This flag is checked when a timer is removed to ensure that the timer's queue isn't deleted while it is in a callback triggered by onQueueTimerFired.

Signed-off-by: Craig Radcliffe <craig.radcliffe@broadcom.com>
Signed-off-by: Shikugawa <rei@tetrate.io>
Signed-off-by: Shikugawa <rei@tetrate.io>
Co-authored-by: Matt Klein <mklein@lyft.com>
…yproxy#15233)

envoyproxy#10854 inadvertently changed the behavior of connect timeouts. This reinstates prior behavior.

Risk Level: Low (reinstating prior behavior)
Testing: added regression test
Docs Changes: n/a
Release Notes: inline

Signed-off-by: Shikugawa <rei@tetrate.io>
Co-authored-by: alyssawilk <alyssar@chromium.org>
@google-cla
Copy link

google-cla bot commented Mar 11, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Mar 11, 2021
@lambdai lambdai added cla: yes and removed cla: no labels Mar 11, 2021
@PiotrSikora
Copy link

@howardjohn could you merge this (not squash) once the CI passes? We need to find a better way to do this, though, since most of those commits are already merged, but squashed in the previous sync commit (#294).

@howardjohn
Copy link
Member

/retest

@howardjohn howardjohn added the tide/merge-method-merge Merge instead of squash label Mar 11, 2021
@howardjohn
Copy link
Member

@PiotrSikora if we want to try it out just remove the hold

@PiotrSikora
Copy link

Thanks!

@istio-testing istio-testing merged commit cd1f21e into istio:release-1.8 Mar 11, 2021
@PiotrSikora
Copy link

History retained, perfect!

@lambdai lambdai deleted the i18-e1.16-0311 branch March 12, 2021 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants