Skip to content

Conversation

jplevyak
Copy link

Remove redundant type checks from WASM calls.

@jplevyak jplevyak requested a review from PiotrSikora February 23, 2019 01:01
@istio-testing
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lambdai
Copy link

lambdai commented Feb 26, 2019

LGTM

@jplevyak jplevyak merged commit 241fec3 into istio:wasm Feb 26, 2019
@jplevyak jplevyak deleted the wasm-unchecked branch February 26, 2019 20:42
fpesce pushed a commit that referenced this pull request Jun 12, 2020
* build: bump nghttp2 to 1.41.0. (envoyproxy#11412)

See release notes at
https://github.com/nghttp2/nghttp2/releases/tag/v1.41.0.

This addresses
GHSA-q5wr-xfw9-q7xr.

Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>

* build: bump nghttp2 to 1.41.0. (envoyproxy#11412)

See release notes at
https://github.com/nghttp2/nghttp2/releases/tag/v1.41.0.

This addresses
GHSA-q5wr-xfw9-q7xr.

Set nghttp2 internal flood mitigation threshold back to 10K to avoid any
changes in Envoy's codec behavior.

Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Yan Avlasov <yavlasov@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Co-authored-by: htuch <htuch@users.noreply.github.com>
istio-testing pushed a commit that referenced this pull request Jun 16, 2020
* build: bump nghttp2 to 1.41.0. (envoyproxy#11412)

See release notes at
https://github.com/nghttp2/nghttp2/releases/tag/v1.41.0.

This addresses
GHSA-q5wr-xfw9-q7xr.

Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>

* build: bump nghttp2 to 1.41.0. (envoyproxy#11412)

See release notes at
https://github.com/nghttp2/nghttp2/releases/tag/v1.41.0.

This addresses
GHSA-q5wr-xfw9-q7xr.

Set nghttp2 internal flood mitigation threshold back to 10K to avoid any
changes in Envoy's codec behavior.

Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Yan Avlasov <yavlasov@google.com>
Signed-off-by: Piotr Sikora <piotrsikora@google.com>

Co-authored-by: htuch <htuch@users.noreply.github.com>

Co-authored-by: Yuchen Dai <silentdai@gmail.com>
Co-authored-by: htuch <htuch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants