Skip to content

Update WAVM to Feb 14 2019 to fix memory leak in exception handling. #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 22, 2019
Merged

Update WAVM to Feb 14 2019 to fix memory leak in exception handling. #28

merged 2 commits into from
Feb 22, 2019

Conversation

jplevyak
Copy link

Update WAVM to Feb 14 2019 to fix memory leak in exception handling.

@jplevyak jplevyak requested a review from PiotrSikora February 22, 2019 00:12
@istio-testing
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers:

If they are not already assigned, you can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

PiotrSikora
PiotrSikora reviewed Feb 22, 2019
View reviewed changes
ci/build_container/build_recipes/wavm.sh Outdated
@@ -31,8 +31,8 @@ cp -pR include/ "$THIRDPARTY_BUILD"/lib/llvm-6.0/include/

# WAVM.

COMMIT=69d647ecf6d355921b79a58aa6b1d674a76b4c2b # 2019-01-24
SHA256=b0789161eb96cc0695cda6e0ea0b2db0bd1919795cebf5d139d66a173234d301
COMMIT=d3607084b98017243cefe699064d4d5cf3f50fd9 # Thu Feb 14 13:12:32 2019 -0500
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason not to update it to latest version (i.e. 275e15fff5928d5cac3b8c5410c5a3b3fa7168ac)?

PiotrSikora
PiotrSikora approved these changes Feb 22, 2019
View reviewed changes
Copy link

@PiotrSikora PiotrSikora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the commit message in squashed commit when merging. Thanks!

/lgtm

@istio-testing
Copy link

@PiotrSikora: changing LGTM is restricted to assignees, and assigning you to the PR failed.

In response to this:

Please update the commit message in squashed commit when merging. Thanks!

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jplevyak jplevyak merged commit 1c34c71 into istio:wasm Feb 22, 2019
@jplevyak jplevyak deleted the wasm-wavm-upgrade branch February 22, 2019 02:22
jplevyak pushed a commit to jplevyak/envoy that referenced this pull request Aug 13, 2019
@yanavlasov @PiotrSikora
connection: always disable reads when connection is closed with the F…
79cbdca 
…lushWriteAndDelay (istio#28)

Signed-off-by: Yan Avlasov <yavlasov@google.com>
rlenglet pushed a commit that referenced this pull request Aug 13, 2019
@jplevyak
Expose Node attributes. Support Listener metadata. Support Cluster M… (…
19b9fd9 
…#28)

* Expose Node attributes. Support Listener metadata.  Support Cluster Metadata.
brian-avery pushed a commit that referenced this pull request Jun 11, 2020
@lambdai @htuch
build: bump nghttp2 to 1.41.0. (envoyproxy#11412) (#28)
8f74aa3 
See release notes at
https://github.com/nghttp2/nghttp2/releases/tag/v1.41.0.

This addresses
GHSA-q5wr-xfw9-q7xr.

Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>

Co-authored-by: htuch <htuch@users.noreply.github.com>
istio-testing pushed a commit that referenced this pull request Jun 12, 2020
@jacob-delgado @lambdai @htuch
build: bump nghttp2 to 1.41.0. (envoyproxy#11412) (#28) (#221)
71de2b0 
See release notes at
https://github.com/nghttp2/nghttp2/releases/tag/v1.41.0.

This addresses
GHSA-q5wr-xfw9-q7xr.

Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>

Co-authored-by: htuch <htuch@users.noreply.github.com>

Co-authored-by: Yuchen Dai <silentdai@gmail.com>
Co-authored-by: htuch <htuch@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@PiotrSikora PiotrSikora PiotrSikora approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jplevyak @istio-testing @PiotrSikora