Skip to content

Conversation

SkyfireFrancisZ
Copy link
Contributor

adding pmerrison as RM and creating 1.17 RM section

adding pmerrison as RM and creating 1.17 RM section
@SkyfireFrancisZ SkyfireFrancisZ requested a review from a team as a code owner January 4, 2023 19:51
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 4, 2023
@ericvn
Copy link
Contributor

ericvn commented Jan 4, 2023

I think the issue here is pmerrison is not a member of the Istio community and in members.yaml (which he should have been for 3 months by https://github.com/istio/istio/wiki/release-manager-expectations).

@ericvn
Copy link
Contributor

ericvn commented Jan 18, 2023

/test test

@ericvn
Copy link
Contributor

ericvn commented Jan 18, 2023

/test test

last one failed with a container issue

@johnma14
Copy link

/test test

@kfaseela
Copy link
Member

@ericvn @howardjohn @linsun approve?

@ericvn
Copy link
Contributor

ericvn commented Jan 19, 2023

Discussed during Combined WG call to have @pmerrison get a PR merged to become member. That was merged in another PR and fixes the test failure here (RMs need to be a member).

@istio-testing istio-testing merged commit cdc1058 into istio:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants