Skip to content

Add label for cherrypick/release-1.17 #615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2023
Merged

Add label for cherrypick/release-1.17 #615

merged 1 commit into from
Jan 18, 2023

Conversation

pmerrison
Copy link
Contributor

No description provided.

@pmerrison pmerrison requested a review from a team as a code owner January 18, 2023 18:38
@istio-policy-bot
Copy link

😊 Welcome @pmerrison! This is either your first contribution to the Istio bots repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 18, 2023
@istio-testing
Copy link
Contributor

Hi @pmerrison. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmerrison pmerrison mentioned this pull request Jan 18, 2023
Merged
5 tasks
johnma14
johnma14 approved these changes Jan 18, 2023
View reviewed changes
Copy link

@johnma14 johnma14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Paul.

@johnma14
Copy link

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Jan 18, 2023
@istio-testing istio-testing merged commit d5b9231 into istio:master Jan 18, 2023
@johnma14 johnma14 mentioned this pull request Jan 18, 2023
Closed
37 tasks
@pmerrison pmerrison mentioned this pull request Mar 23, 2023
Closed
30 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@johnma14 johnma14 johnma14 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pmerrison @istio-policy-bot @istio-testing @johnma14