unhide faults from virtual service #405
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fault filter can be implemented with the current API spec, with a small loss of perf (repeated header matching). It is independent of the work involving route-local filter stacks.
We need to enable it in the LDSv2 and v1alpha3, so as not to cause a regression in current feature set.
The semantics are as follows:
cc @kyessenov @ostromart @ijsnellf @louiscryan