Skip to content

Remove EUC policy API #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 23, 2018
Merged

Remove EUC policy API #456

merged 2 commits into from
Apr 23, 2018

Conversation

diemtvu
Copy link
Contributor

@diemtvu diemtvu commented Apr 19, 2018

@diemtvu diemtvu requested review from ayj and qiwzhang April 19, 2018 18:22
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Apr 19, 2018
@ayj
Copy link
Contributor

ayj commented Apr 19, 2018

Should the remaining references in istio/istio be deleted first?

$ grep -rn EndUserAuthenticationPolicySpec pilot/ |wc -l 
38

@qiwzhang
Copy link
Contributor

It is still used here https://github.com/istio/proxy/blob/master/src/envoy/http/mixer/filter_factory.cc#L36

@diemtvu
Copy link
Contributor Author

diemtvu commented Apr 20, 2018

Thanks for checking. These refs have been removed in recent PRs istio/istio#5080 and istio/proxy#1477. We should be good now. PTAL

@diemtvu diemtvu merged commit 9868341 into istio:master Apr 23, 2018
@diemtvu diemtvu deleted the cleanup-euc branch April 23, 2018 20:06
@incfly incfly mentioned this pull request Apr 25, 2018
Closed
hklai pushed a commit that referenced this pull request Apr 27, 2018
@diemtvu @hklai
Remove EUC policy API (#456)
7aa32a6 
* Remove EUC poliyc API

* Add missing change
incfly pushed a commit to incfly/api that referenced this pull request Jun 13, 2018
@mtakigiku @qiwzhang
jwt-auth: make audiences configurable for each issuer (istio#456)
53f299a 
* make audiences configurable for each issuer

* audience -> audiences

* change function name and use std::find()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@ayj ayj ayj approved these changes

@qiwzhang qiwzhang qiwzhang approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@diemtvu @ayj @qiwzhang @googlebot