Skip to content

Conversation

richardwxn
Copy link
Contributor

for istio/istio#32005

v2beta1 was deprecated in 1.19 and to be removed in 1.25

@istio-policy-bot
Copy link

😊 Welcome @richardwxn! This is either your first contribution to the Istio api repo, or it's been
awhile since you've been here.

You can learn more about the Istio working groups, code of conduct, and contributing guidelines
by referring to Contributing to Istio.

Thanks for contributing!

Courtesy of your friendly welcome wagon.

@istio-testing istio-testing added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 10, 2022
@richardwxn
Copy link
Contributor Author

richardwxn commented Mar 15, 2022

@howardjohn PTAL. Not sure why make gen have generated unrelated update though

@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Mar 17, 2022
@linsun
Copy link
Member

linsun commented Mar 21, 2022

changes look reasonable to me.

@howardjohn
Copy link
Member

Waiting for istio/istio#37872 (comment) to make sure it works before merging

1 similar comment
@howardjohn
Copy link
Member

Waiting for istio/istio#37872 (comment) to make sure it works before merging

@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Mar 28, 2022
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Apr 12, 2022
@istio-policy-bot istio-policy-bot added the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label May 3, 2022
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label May 3, 2022
@istio-policy-bot istio-policy-bot removed the lifecycle/stale Indicates a PR or issue hasn't been manipulated by an Istio team member for a while label May 5, 2022
@richardwxn richardwxn added this to the 1.14 milestone May 5, 2022
@richardwxn richardwxn added the cherrypick/release-1.14 Set this label on a PR to auto-merge it to the release-1.14 branch label May 5, 2022
@richardwxn
Copy link
Contributor Author

@ericvn @jacob-delgado can you PTAL as it is a release blocker for 1.14

@ostromart ostromart self-requested a review May 5, 2022 22:05
@istio-testing
Copy link
Collaborator

In response to a cherrypick label: new pull request created: #2340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherrypick/release-1.14 Set this label on a PR to auto-merge it to the release-1.14 branch size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants