Skip to content

Run make gen with the new build-tools to generate new html #2509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

ericvn
Copy link

@ericvn ericvn commented Oct 14, 2022

The new build-tools has a new markdown generator for the html files (same as the one used by istio.io. The PR is simply make gen with the new build-image to update the html files.

This PR is needed to prevent other PRs from having to check these changes in.

@ericvn ericvn requested a review from a team as a code owner October 14, 2022 20:17
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 14, 2022
@ericvn
Copy link
Author

ericvn commented Oct 14, 2022

The gen-check test will pass when the pipeline moves to the same image as the istio/api repos is using.

@ericvn ericvn added the release-notes-none Indicates a PR that does not require release notes. label Oct 14, 2022
@ericvn
Copy link
Author

ericvn commented Oct 14, 2022

/test release-notes

@zirain
Copy link
Member

zirain commented Oct 15, 2022

/test gencheck

@zirain
Copy link
Member

zirain commented Oct 15, 2022

@ericvn this should merge first?

@ericvn
Copy link
Author

ericvn commented Oct 16, 2022

@zirain I was waiting for the 2 needed approvals for this PR. Once the approvals are in place, I will merge istio/test-infra#4331 which will update the pipeline to use the new image. At that point, the gencheck for this PR will pass and then merge.

If I simply merge the test-infra PR, then the gencheck will fail in other PRs unless they also include these changes for all files, not just what they are changing.

If a user tries to run make gen on the current commit and submit the PR, they will have the same gencheck failure this PR does as the repo and tooling are out of sync.

Hopefully, we can get the two PRs merged soon.

@ericvn
Copy link
Author

ericvn commented Oct 17, 2022

/test gencheck

@istio-testing istio-testing merged commit a51f8f8 into istio:master Oct 17, 2022
@ericvn ericvn deleted the runMakeGen branch October 17, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants