Skip to content

Running make gen #2446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Running make gen #2446

merged 1 commit into from
Aug 4, 2022

Conversation

kfaseela
Copy link
Member

@kfaseela kfaseela commented Aug 4, 2022

Running make gen for some other API change which I am working on, resulted in many additional
changes showing up in my local repo. So pushing a separate review for the same to check if this is relevant.

Signed-off-by: Faseela K faseela.k@est.tech

Running make gen for some other change resulted in many additional
changes showing up in my local repo. So pushing a separate review for the same.

Signed-off-by: Faseela K <faseela.k@est.tech>
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 4, 2022
@kfaseela kfaseela added the release-notes-none Indicates a PR that does not require release notes. label Aug 4, 2022
@kfaseela
Copy link
Member Author

kfaseela commented Aug 4, 2022

/test release-notes_api

@ericvn
Copy link

ericvn commented Aug 4, 2022

Another repo with a needed make gen do to the Go 1.19 update (doc formatting change in 1.19).

@istio-testing istio-testing merged commit d1ffe5e into istio:master Aug 4, 2022
@ericvn
Copy link

ericvn commented Aug 4, 2022

/cherry-pick release-1.15

@istio-testing
Copy link
Collaborator

@ericvn: new pull request created: #2449

In response to this:

/cherry-pick release-1.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kfaseela kfaseela deleted the run-make-gen branch August 5, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants