Skip to content

Add release 1.7 release lock #1551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Add release 1.7 release lock #1551

wants to merge 1 commit into from

Conversation

jwendell
Copy link
Member

No description provided.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Jul 22, 2020
@istio-testing istio-testing added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 22, 2020
@jwendell
Copy link
Member Author

Please advice. I copied 1.6 files and ran the script, which generates the status file, which is the same as in 1.6. Is that right?

@jacob-delgado jacob-delgado mentioned this pull request Jul 22, 2020
Closed
52 tasks
@JimmyCYJ
Copy link
Member

@jasonwzm could you help to take a look?

@jasonwzm
Copy link
Member

@jwendell Can you follow https://github.com/istio/api/blob/master/scripts/check-release-locks.md? Basically we copy the status file in the release-1.7 branch into release-1.7 folder on master branch.

@jwendell
Copy link
Member Author

@jasonwzm I did that.

@jwendell
Copy link
Member Author

@rshriram can you take a look at this?

@istio-testing
Copy link
Collaborator

@jwendell: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
build_api 59852b6 link /test build_api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jwendell
Copy link
Member Author

I've rebased this against master
Here's what I did:

  • checkout to 1.7
  • rm proto.lock && protolock init && mv proto.lock xuxa
  • commented rm line on check-release-notes.sh && run it
  • checkout to master
  • mv xuxa releaselocks/release-1.7/proto.lock
  • mv status releaselocks/release-1.7/proto.lock.status
  • commit & push to this pr

make release-lock-status is failing both for me locally and on this pr. What's missing?

@jwendell jwendell mentioned this pull request Aug 5, 2020
Merged
@jwendell jwendell closed this Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcberg dcberg Awaiting requested review from dcberg

@duderino duderino Awaiting requested review from duderino

@linsun linsun Awaiting requested review from linsun

@louiscryan louiscryan Awaiting requested review from louiscryan

@rshriram rshriram Awaiting requested review from rshriram

@smawson smawson Awaiting requested review from smawson

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jwendell @JimmyCYJ @jasonwzm @istio-testing @googlebot