-
Notifications
You must be signed in to change notification settings - Fork 445
refactorization and SQLAlchemy #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also handle mutable datastructures more carefully.
share/isso.conf symlink actually. Fix broken isso.dispatch module.
* add a wrapper around `sqlite3` to enable connection pooling across multiple threads. Most tests now use a in-memory database which speeds things (slightly) up. The database wrapper is now uncoupled from the actual database connection. * split cache framework from core.Mixin into a separate package `isso.cache`. The dependency on `werkzeug.contrib` has been removed to ease a possible transition to a different web framework later. The default cache uses SQLite3 now (unless Isso is run from uWSGI). While it may sound like a Bad Idea (tm), it's much more efficient than per-process python datastructures. The SQLite3 cache is SMP-capable and fast for read-heavy sites. SQLite3 may fail due to a corrupt database for concurrent read access from multiple processes. The database is actually not corrupted, but the connection is stale. As a workaround, limit process number to your CPU count or wait until a "real" backend such as PostgreSQL is available.
The sanitizer is written in Python and rather slow for many comments
* atexit is ignored by uWSGI and the worker thread can not exit * queue API and naming is not final Gunicorn ignores an error on shutdown: Exception SystemExit: 0 in <module 'threading' from '/usr/lib64/python2.7/threading.pyc'> ignored
* no timedelta.total_seconds * no functools.total_ordering EOL.
Conflicts: MANIFEST.in docs/docs/install.rst isso/tests/test_html.py
* split db/view into model, controller and views * use SQLAlchemy for comments, threads and preferences
Update config sample to work with SQLAlchemy
Update .gitignore
Escaping is done in Jade templates (by default).
... still ugly.
Conflicts: isso/views/comments.py
This was referenced Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress.
Refactoring
API.fetch
into controllerAny new TODO/FIXME comment.
SQLAlchemy
SQLite3Cache
with SASQLite3Queue
with SAUI