Skip to content

Fix check in ConvertFromPinholeCameraParameters function from ViewControl #6711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2024
Merged

Fix check in ConvertFromPinholeCameraParameters function from ViewControl #6711

merged 3 commits into from
Apr 17, 2024

Conversation

lumurillo
Copy link
Contributor

The ViewControl's ConvertFromPinholeCameraParameters function was always failing due to an

Type

  • Bug fix (non-breaking change which fixes an issue): Fixes #
  • New feature (non-breaking change which adds functionality). Resolves #
  • Breaking change (fix or feature that would cause existing functionality to not work as expected) Resolves #

Motivation and Context

The ViewControl's ConvertFromPinholeCameraParameters was failing.

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results       (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.
  • For fork PRs, I have selected Allow edits from maintainers.

Description

In one of the if statements of the ConvertFromPinholeCameraParameters there was an error when comparing the intrisinic height with the window height.

@update-docs Update Docs
Copy link

update-docs bot commented Mar 20, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@ssheorey ssheorey requested a review from errissa March 20, 2024 23:25
ssheorey
ssheorey approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@ssheorey ssheorey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@ssheorey ssheorey merged commit 74dcbe8 into isl-org:main Apr 17, 2024
@nicolaloi
Copy link
Contributor

nicolaloi commented May 19, 2024 •
edited
Loading

This should close issue #6666, and probably also issue #6617

@javrtg javrtg mentioned this pull request Jun 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssheorey ssheorey ssheorey approved these changes

@errissa errissa Awaiting requested review from errissa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lumurillo @nicolaloi @ssheorey