fix: bundling library using webpack #190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased to current |
|
What a very bizarre requirement. But ok, sure. I'll update the other hybrid modules I have to work the same way. |
|
Thanks! ❤️ |
isaacs
added a commit
to isaacs/node-mkdirp
that referenced
this pull request
Jan 17, 2023
this change ensures "default" conditions are last, fixing the following webpack bundling error: ``` Module not found: Error: Default condition should be last one ``` Re: isaacs/minimatch#190 Credit: @AviVahl Reviewed-by: @isaacs
isaacs
added a commit
to isaacs/rimraf
that referenced
this pull request
Jan 17, 2023
this change ensures "default" conditions are last, fixing the following webpack bundling error: ``` Module not found: Error: Default condition should be last one ``` Re: isaacs/minimatch#190 Credit: @AviVahl Reviewed-by: @isaacs
isaacs
added a commit
to isaacs/node-glob
that referenced
this pull request
Jan 18, 2023
this change ensures "default" conditions are last, fixing the following webpack bundling error: ``` Module not found: Error: Default condition should be last one ``` Re: isaacs/minimatch#190 Credit: @AviVahl Reviewed-by: @isaacs
isaacs
added a commit
to isaacs/node-glob
that referenced
this pull request
Feb 27, 2023
this change ensures "default" conditions are last, fixing the following webpack bundling error: ``` Module not found: Error: Default condition should be last one ``` Re: isaacs/minimatch#190 Credit: @AviVahl Reviewed-by: @isaacs
afzalimdad9
added a commit
to afzalimdad9/minimatch
that referenced
this pull request
Jan 18, 2025
this change ensures "default" conditions are last, fixing the following webpack bundling error: ``` Module not found: Error: Default condition should be last one ``` PR-URL: isaacs/minimatch#190 Credit: @AviVahl Close: #190 Reviewed-by: @isaacs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this change ensures "default" conditions are last, fixing the following webpack bundling error (on import to lib):