Skip to content

Conversation

progval
Copy link
Contributor

@progval progval commented Apr 1, 2022

They are typical replies when using the HELP command.

Tested on Ergo, using /quote HELP MODE

Before:
screenshot-2022-04-01_15-02-27

After:
screenshot-2022-04-01_15-49-08

@ailin-nemui
Copy link
Contributor

524 is already used to notify about Quarantined channels, it would not be good to bind it as "help not found"

@progval
Copy link
Contributor Author

progval commented Apr 7, 2022

Yes, but ERR_HELPNOTFOUND is more widespread:

  • 524 is ERR_HELPNOTFOUND on irc-ratbox and derivatives (Hybrid, Solanum, Plexus, ...), InspIRCd, and Ergo. This covers 6 of the top 10 networks (according to netsplit.de).
  • UnrealIRCd may also start using it as ERR_HELPNOTFOUND in a few years depending on client support.
  • 524 is ERR_QUARANTINED on ircu2 derivatives (Nefarious, snircd, ...) except UnrealIRCd. This covers 2 of the top 10.

What do you usually do when numerics clash between servers?

@ailin-nemui
Copy link
Contributor

we would need to detect which one it is, probably by using a strcmp and see if the response contains :Help, so that we can display the right one. quarantined channels also contain the quarantine reason, wouldn't want to hide that for sure

@progval
Copy link
Contributor Author

progval commented Apr 20, 2022

Hmm that might fail because :Help is not guaranteed to be a substring of the ERR_HELPNOTFOUND message.

However, we could check if the second parameter starts with one of the ISUPPORT PREFIX character; it's unlikely to be a valid topic name. Agreed?

@ailin-nemui
Copy link
Contributor

ailin-nemui commented Apr 20, 2022

sadly that's not so cool either, if we do /shelp #xxx then it would trigger the quarantine code path??

maybe just leave the 524 unhandled (sad but less work)?

Edit: according to https://www.alien.net.au/irc/irc2numerics.html, 524 could also be in use for ERR_OPERSPVERIFY

@progval
Copy link
Contributor Author

progval commented Apr 20, 2022

Ah, sad. I'll remove it, then.

@ailin-nemui
Copy link
Contributor

ailin-nemui commented Apr 21, 2022

thanks for the improvement, merged into ailin-nemui#82

@ailin-nemui ailin-nemui added this to the 1.4.0 milestone May 29, 2022
@progval progval deleted the help branch June 11, 2022 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants