-
Notifications
You must be signed in to change notification settings - Fork 372
Format RPL_HELPSTART/RPL_HELPTXT/RPL_ENDOFHELP #1371
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
524 is already used to notify about Quarantined channels, it would not be good to bind it as "help not found" |
Yes, but ERR_HELPNOTFOUND is more widespread:
What do you usually do when numerics clash between servers? |
we would need to detect which one it is, probably by using a strcmp and see if the response contains :Help, so that we can display the right one. quarantined channels also contain the quarantine reason, wouldn't want to hide that for sure |
Hmm that might fail because However, we could check if the second parameter starts with one of the ISUPPORT |
sadly that's not so cool either, if we do /shelp #xxx then it would trigger the quarantine code path?? maybe just leave the 524 unhandled (sad but less work)? Edit: according to https://www.alien.net.au/irc/irc2numerics.html, 524 could also be in use for |
Ah, sad. I'll remove it, then. |
thanks for the improvement, merged into ailin-nemui#82 |
They are typical replies when using the HELP command.
Tested on Ergo, using
/quote HELP MODE
Before:

After:
