fail on empty text #1299
Merged
fail on empty text #1299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lastlog reuses the same GString with every call of textbuffer_line2text, and depends on this function truncating the GString, otherwise when this particular edge case triggers, you'll end up with multiple copies of the same line printed by lastlog. Either test after the truncation, or make lastlog do the truncation itself before calling textbuffer_line2text. (Originally reported to me by @mnordhoff) |
reported by @dwfreed
24afd11 to
dee0554
Compare
|
moved it to after the truncation. the actual bug (reason unclear) is the line not having a text |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reported by @dwfreed