Add a check for term.h #1290
Merged
Add a check for term.h #1290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the contribution! small nit pick, could you indent the snippet in the configure.ac so it is visually within the |
If term.h is present, use that instead of defining prototypes for the terminfo functions in terminfo-core.c. This causes problems on certain platforms (e.g. Apple aarch64) due to the functions being prototyped as non-variadic but called as variadic. If term.h isn't found, it falls back to the old behaviour. Fixes irssi#1238.
e5f56a7 to
0b82f14
Compare
|
Sure thing! Done. |
|
I tested it on Solaris, works as expected |
|
@irssi/developers |
5 tasks
ailin-nemui
added a commit
that referenced
this pull request
Apr 8, 2021
Add a check for term.h (cherry picked from commit a731525)
|
Just to double-check: this landed in 1.2.3, right? I wasn't sure because the tag doesn't show up in the merged commit. This would be good to know before merging Homebrew/homebrew-core#75094, which removes patches backported from this PR. Thanks! |
|
Yes, I see this in 1.2.3's source: https://github.com/irssi/irssi/blob/1.2.3/configure.ac#L372-L374 Looks like it made it into the generated |
|
Saw that too; just wanted to make sure I wasn't missing anything. Thanks, @mistydemeo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
term.his present, use that instead of defining prototypes for the terminfo functions interminfo-core.c. This causes problems on certain platforms (e.g. Apple aarch64) due to the functions being prototyped as non-variadic but called as variadic. Ifterm.hisn't found, it falls back to the old behaviour.This fixes #1238; I was able to test on my Apple ARM Mac and it builds/works as expected using the system curses. I wasn't able to test the meson build since it's failing for me for unrelated reasons, but I think my fix should fix that as well.