fix invalid unsigned arithmetic. #1269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks for the report, would you be interested in following through and applying the style patch as well: https://github.com/irssi/irssi/pull/1269/checks?check_run_id=1839878784#step:5:9 by the way did you or your automated checker find any other cases in the code? maybe there are more cases of signed -> unsigned |
currently I see only this error. ( |
|
@irssi/developers |
ailin-nemui
added a commit
that referenced
this pull request
Apr 8, 2021
fix invalid unsigned arithmetic. (cherry picked from commit 0dd6075)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe your checks are not correct.
in my opinion they are equivalent to checks
!=.I suggest a simple fix.