Skip to content

correct wrong function prefixes #1246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jan 30, 2021
Merged

correct wrong function prefixes #1246

merged 9 commits into from
Jan 30, 2021

Conversation

ailin-nemui
Copy link
Contributor

@ailin-nemui ailin-nemui commented Jan 4, 2021 •
edited
Loading

  • g_input -> i_input
  • g_istr -> i_istr
  • g_io_channel -> i_io_channel
  • g_hash_free_value -> i_hash_free_value
  • remove g_free_true
  • gslist -> i_slist
  • glog_func -> i_log_func

@ailin-nemui
Copy link
Contributor Author

We were clobbering the GLib prefix. Note，this is a tad annoying change but better to get over with it

@ailin-nemui
Copy link
Contributor Author

ailin-nemui commented Jan 4, 2021 •
edited
Loading

Module authors will have to adapt these changes:

    [M] 'constant I_INPUT_READ'    {G_INPUT_READ}
    [M] 'constant I_INPUT_WRITE'    {G_INPUT_WRITE}
    [M] 'function int i_input_add(GIOChannel*, int, GInputFunction, void*)'    {g_input_add}
    [M] 'function int i_input_add_full(GIOChannel*, int, int, GInputFunction, void*)'    {g_input_add_full}
    [M] 'function int i_input_add_poll(int, int, int, GInputFunction, void*)'    {g_input_add_poll}
    [M] 'function GIOChannel* i_io_channel_new(int)'    {g_io_channel_new}
    [M] 'function int i_io_channel_read_block(GIOChannel*, void*, int)'    {g_io_channel_read_block}
    [M] 'function int i_io_channel_write_block(GIOChannel*, void*, int)'    {g_io_channel_write_block}
    [M] 'function int i_istr_cmp(gconstpointer, gconstpointer)'    {g_istr_cmp}
    [M] 'function int i_istr_equal(gconstpointer, gconstpointer)'    {g_istr_equal}
    [M] 'function guint i_istr_hash(gconstpointer)'    {g_istr_hash}
    [M] 'function void i_log_func(const char*, GLogLevelFlags, const char*)'    {glog_func}
    [M] 'function GSList* i_slist_delete_string(GSList*, const char*, GDestroyNotify)'    {gslist_delete_string}
    [M] 'function GSList* i_slist_find_icase_string(GSList*, const char*)'    {gslist_find_icase_string}
    [M] 'function GSList* i_slist_find_string(GSList*, const char*)'    {gslist_find_string}
    [M] 'function void* i_slist_foreach_find(GSList*, FOREACH_FIND_FUNC, void*)'    {gslist_foreach_find}
    [M] 'function void i_slist_free_full(GSList*, GDestroyNotify)'    {gslist_free_full}
    [M] 'function GSList* i_slist_remove_string(GSList*, const char*)'    {gslist_remove_string}
    [M] 'function char* i_slist_to_string(GSList*, const char*)'    {gslist_to_string}

@dequis
Copy link
Member

dequis commented Jan 4, 2021

Ugh.

Any particular motivation for this change? Did it finally become a problem?

@ailin-nemui
Copy link
Contributor Author

just doing clean-up work. what's your opinion? better delay indefinitely :-)?

@ailin-nemui ailin-nemui merged commit db9aa81 into irssi:master Jan 30, 2021
@ailin-nemui ailin-nemui deleted the wrong-prefixes branch January 30, 2021 20:09
@ailin-nemui
Copy link
Contributor Author

merging this after discussion with dequis who doesn't like it. But it's better to fix mistakes. We had one break already in the past with ssl->tls

@ailin-nemui ailin-nemui mentioned this pull request Jan 30, 2021
Merged
ailin-nemui pushed a commit to ailin-nemui/irssi-xmpp that referenced this pull request Apr 8, 2021
restore compatibility with fixed Irssi prefixes
36d47f8 
this is for irssi/irssi#1246 and irssi/irssi#1264

Fixes build with Irssi 1.3
@ailin-nemui ailin-nemui mentioned this pull request Apr 8, 2021
Open
ailin-nemui pushed a commit to ailin-nemui/irssi-xmpp that referenced this pull request Apr 8, 2021
restore compatibility with fixed Irssi prefixes
676acc6 
this is for irssi/irssi#1246 and irssi/irssi#1264

Fixes build with Irssi 1.3
@ailin-nemui ailin-nemui added this to the 1.3.0 milestone Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ailin-nemui @dequis