Skip to content

refactor quit message into a separate function #1100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 15, 2019
Merged

refactor quit message into a separate function #1100

merged 1 commit into from
Aug 15, 2019

Conversation

ailin-nemui
Copy link
Contributor

No description provided.

@dequis
Copy link
Member

dequis commented Aug 15, 2019

Context: This refactor is currently a commit in a bunch of other PRs implementing ircv3 caps (#1096, #1098, #1099) and I asked to have this split to its own PR to simplify the review process

@ailin-nemui ailin-nemui force-pushed the spread_server_message_to_windows branch from a61c53f to 0f361d2 Compare August 15, 2019 14:02
@ailin-nemui
Copy link
Contributor Author

I "moved the part handler up" so the patch is less confusing

@ailin-nemui ailin-nemui merged commit f7e67b9 into irssi:master Aug 15, 2019
@ailin-nemui ailin-nemui deleted the spread_server_message_to_windows branch August 15, 2019 14:15
@ailin-nemui ailin-nemui added this to the 1.3.0 milestone Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dequis dequis dequis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ailin-nemui @dequis