Add better support for numeric 489 ERR_SECUREONLYCHAN along with a print format #1196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…int format modified: src/fe-common/irc/fe-events-numeric.c modified: src/fe-common/irc/module-formats.c modified: src/fe-common/irc/module-formats.h
|
thanks :-) |
added 3 commits
May 16, 2020 00:48
modified: src/common.h
modified: src/fe-common/irc/fe-events-numeric.c
…mat strictnes got tightened modified: src/fe-common/irc/fe-events-numeric.c modified: src/fe-common/irc/module-formats.c modified: src/fe-common/irc/module-formats.h
|
Now the failed tests have been fixed and I tested the ERR_VOICENEEDED on undernet with success. Hopefully no more loose ends. |
…bove it. modified: src/fe-common/irc/fe-events-numeric.c
|
@irssi/developers |
|
Sure, looks solid. We should do something about those |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt at adding support for numeric 489 as ERR_SECUREONLYCHAN in addition to the already supported ERR_VOICENEEDED. To fix my own submitted issue #1193
It adds a new event_489 handler and the format string 'joinerror_secure_only'. but it is not unlikely i have missed some other (required) details for adding a numeric and format string.
It is ofcourse tested (at least for ERR_SECUREONLYCHAN, i dont know where it is used as ERR_VOICENEEDED so cant test triggering that) and "it works on my computer" :-)
modified: src/fe-common/irc/fe-events-numeric.c
modified: src/fe-common/irc/module-formats.c
modified: src/fe-common/irc/module-formats.h