Skip to content

Conversation

Pinguin1234
Copy link
Contributor

@Pinguin1234 Pinguin1234 commented Apr 3, 2020

Fixes Issue #828

@ailin-nemui
Copy link
Contributor

nice!

@ailin-nemui
Copy link
Contributor

@irssi/developers

@ailin-nemui
Copy link
Contributor

you think this is good now @dequis ?

@dequis
Copy link
Member

dequis commented Apr 6, 2020

Yeah, definitely okay from the signal side. Is sighup_received an ABI change? At least I can't imagine that change breaking anything, it's internal enough.

@ailin-nemui
Copy link
Contributor

@Pinguin1234 please indent your code with TAB

and increase the ABI_VERSION in common.h

@Pinguin1234
Copy link
Contributor Author

Pinguin1234 commented Apr 6, 2020 via email

@ailin-nemui ailin-nemui merged commit f1647bd into irssi:master Apr 6, 2020
@Pinguin1234 Pinguin1234 deleted the feature/close_on_sighup branch April 6, 2020 15:32
@ailin-nemui ailin-nemui added this to the 1.3.0 milestone Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants