Skip to content

Make sure witem exists in cmd_cat when using -window #1159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 10, 2020
Merged

Make sure witem exists in cmd_cat when using -window #1159

merged 4 commits into from
Jul 10, 2020

Conversation

vague666
Copy link
Member

No description provided.

@ailin-nemui
Copy link
Contributor

@vague666 can you test my change?

@vague666
Copy link
Member Author

Works for me, although I'd prefer to print to an itemless window if that's possible, like if item == NULL then Irssi::active_win <-- whatever c code that calls to find a target

@ailin-nemui
Copy link
Contributor

then you can maybe change the code to use

if (-window flag is given) {
    printtext_window(active_win, ...);
} else {
    printtext(NULL, NULL, ...);
}

?

@ailin-nemui ailin-nemui added auto-merge This PR is scheduled for merge if no further comments are opened and removed needs changes labels Jul 7, 2020
@ailin-nemui
Copy link
Contributor

@irssi/developers

@ailin-nemui ailin-nemui merged commit 70626d8 into irssi:master Jul 10, 2020
@ailin-nemui ailin-nemui added this to the 1.3.0 milestone Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
auto-merge This PR is scheduled for merge if no further comments are opened
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@vague666 @ailin-nemui