Reconnect retry IPv4 on IPv6 failure #1146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is really a band-aid because it imposes the standard reconnection timeout (default 5 minutes?) on any attempt to fail over from ipv6 to ipv4 or vice versa. Ideally in the future we'd do one of the following:
|
|
@irssi/developers |
|
nb this will require an abi bump due to added field |
|
@irssi/developers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track the address family of the last failed connection attempt (either immediately or during TLS handshake), then disprefer that address family during reconnection.
A note on testing ipv6 connectivity failure on Linux:
disable_ipv6will not simulate it correctly, because irssi callsgetaddrinfo(3)withAI_ADDRCONFIG, which suppresses resolution of ipv6 addresses if no local ipv6 address is available.The correct way to simulate this is with
disable_ra. That way, the link-local address will remain, andgetaddrinfo(3)will return addresses corresponding to AAAA records, but attempts to connect to them will fail with "Network is unreachable".I tested a few different cases (disable_ra for cutting off ipv6, an iptables rule dropping outgoing packets for cutting off ipv4), but this probably needs more testing --- let me know if you have suggestions.