Skip to content

remove GTimeVal following glib 2.61.2 deprecation #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 8, 2020
Merged

remove GTimeVal following glib 2.61.2 deprecation #1145

merged 2 commits into from
Jan 8, 2020

Conversation

ailin-nemui
Copy link
Contributor

@ailin-nemui ailin-nemui commented Dec 6, 2019 •
edited
Loading

fixes #1144

@ailin-nemui
Copy link
Contributor Author

@dequis #1141

@ailin-nemui ailin-nemui mentioned this pull request Dec 18, 2019
Closed
@dequis
Copy link
Member

dequis commented Jan 1, 2020 

15:36 < dx> [1:bitlbee (change with ^X)] [Lag: 973.33]
15:36 < dx> lol i guess
15:36 < dx> i started irssi before bitlbee, and that's the time since it started the reconnection attempts, shows up as lag for a brief moment
15:39 < dx> (it does this for every network)

Restarted today with git master + this PR merged in.

@ailin-nemui
Copy link
Contributor Author

are you sure that this only happens with this patch?

@dequis
Copy link
Member

dequis commented Jan 6, 2020

Not really, i just commented to not forget about it and check later.

@dequis
Copy link
Member

dequis commented Jan 7, 2020

Confirming: with this commit, irssi shows [Lag: 88.42] for one network, weirdly always that number, a few seconds after startup / successfully connecting to a network. Not correlated to reconnection time as I previously thought.

Valgrind doesn't whine about uninitialized reads but I guess this one doesn't hit a condition.

dequis
dequis reviewed Jan 7, 2020
View reviewed changes
@ailin-nemui @dequis
Update src/irc/core/lag.c
b8be290 
Co-Authored-By: dx <dx@dxzone.com.ar>
@ailin-nemui ailin-nemui added the auto-merge This PR is scheduled for merge if no further comments are opened label Jan 8, 2020
@ailin-nemui
Copy link
Contributor Author

@irssi/developers

@ailin-nemui ailin-nemui merged commit 363a79d into irssi:master Jan 8, 2020
@ailin-nemui ailin-nemui deleted the time branch January 8, 2020 09:41
ailin-nemui pushed a commit to ailin-nemui/irssi-xmpp that referenced this pull request Mar 17, 2020
add compatibility code to GTimeVal -> gint64 transition
5b1a575 
this is for irssi/irssi#1145
@ailin-nemui ailin-nemui mentioned this pull request Mar 17, 2020
Open
ailin-nemui pushed a commit to ailin-nemui/irssi-xmpp that referenced this pull request Mar 17, 2020
add compatibility code to GTimeVal -> gint64 transition
c7728ea 
this is for irssi/irssi#1145
ailin-nemui pushed a commit to ailin-nemui/irssi-xmpp that referenced this pull request Mar 19, 2020
add compatibility code to GTimeVal -> gint64 transition
ffc7be5 
this is for irssi/irssi#1145
@ailin-nemui ailin-nemui added this to the 1.3.0 milestone Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dequis dequis dequis approved these changes

Assignees
No one assigned
Labels
auto-merge This PR is scheduled for merge if no further comments are opened
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

warning: ‘GTimeVal’ is deprecated: Use 'GDateTime' instead [-Wdeprecated-declarations]
2 participants
@ailin-nemui @dequis