Remove unused functions #1017
Merged
Remove unused functions #1017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error flag can be something other than -1 in the event of an error. Not checking for this could lead to us to try connecting to an unknown IP.
|
I checked all modules I could find and none use these functions. (I checked all in #940 and all listed on irssi.org except psyc as I couldn't find that one's code). |
|
sounds good to me, we should bump ABI constant before merge |
|
@irssi/developers |
|
Can we at least go through deprecation in one release? And maybe stub out the contents of the functions, but don't break API just yet |
|
my opinion is that we should skip deprecation
|
|
@irssi/developers please vote on the first post final votes: +2 / -1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a bug in one of these functions but then saw that it wasn't actually even used. So I figure it is better to delete!
These are public so perhaps we don't want to merge yet.
Edited by Nei
Functions to be removed: