support cap away-notify #1099
support cap away-notify #1099
Conversation
src/fe-common/irc/fe-irc-messages.c
Outdated
| @@ -308,6 +342,7 @@ void fe_irc_messages_init(void) | |||
| signal_add_last("message irc notice", (SIGNAL_FUNC) sig_message_irc_notice); | |||
| signal_add_last("message irc own_ctcp", (SIGNAL_FUNC) sig_message_own_ctcp); | |||
| signal_add_last("message irc ctcp", (SIGNAL_FUNC) sig_message_irc_ctcp); | |||
| signal_add_last("message irc away", (SIGNAL_FUNC) sig_message_irc_away); | |||
There was a problem hiding this comment.
Is this the right location for this sort of event? All the others are channel-targeted and this one broadcasts, more like joins or quits, which aren't in this file.
There was a problem hiding this comment.
it's a bit of a question. I felt this event belongs more to IRC than the generic code (where the joins and quits are)
but I think it could be argued either way. I can move it if you think that's better (the message would lose the `irc' bit)
There was a problem hiding this comment.
Yeah nevermind, didn't consider that all the other events are not irc specific, but this one certainly is. That grouping makes more sense than "channel-targeted"
(not that i'm a big fan of allowing irssi to support non-irc protocols, but, whatever, let's keep that design decision)
There was a problem hiding this comment.
Wait nevermind you changed it since I originally wrote this comment. Oops. I.. also don't mind this other version. Like you said, can be argued either way.
There was a problem hiding this comment.
This last version has it in the same file as the spread_server_message_to_windows function, which I'd say is the strongest argument so far.
e762d36 to
6e8de27
Compare
|
I added some commits to move the code to fe-common/core, we can either use these changes or throw them away |
6e8de27 to
4e692f8
Compare
4e692f8 to
5f13614
Compare
No description provided.