add chghost capability support #1096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dequis
reviewed
Aug 14, 2019
src/fe-common/core/fe-messages.c
Outdated
| printformat(server, rec->visible_name, | ||
| level, | ||
| TXT_HOST_CHANGED, nick, address, old_address, | ||
| rec->visible_name); |
There was a problem hiding this comment.
I wonder if we should make it easy for these to be silenced, with a setting or something, or if we should leave it to the standard mechanisms. (Ignores? Probably not because it's sharing levels with join. Removing the format? For some reason I don't like doing that. If that's irrational then ignore me)
There was a problem hiding this comment.
I don't know, originally the host change message causes a quit AND join message. any other @irssi/developers with an opinion?
There was a problem hiding this comment.
I think it's quit/join on freenode, but absolutely nothing in other networks. Yeah, could use other opinions.
There was a problem hiding this comment.
also on quakenet and undernet
b5b40c2 to
9c97a46
Compare
dequis
reviewed
Aug 14, 2019
17efbec to
f7afe83
Compare
dequis
approved these changes
Aug 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.