show invites of other users when provided #1094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e4a217c to
52591d0
Compare
52591d0 to
e62e55c
Compare
dequis
approved these changes
Aug 15, 2019
| signal_emit("message invite", 4, | ||
| server, get_visible_target(server, channel), nick, addr); | ||
| params = event_get_params(data, 2, &invited, &channel); | ||
| if (server->nick_comp_func(invited, server->nick) == 0) { |
There was a problem hiding this comment.
Out-of-scope but this function seems very underused for own-nick comparisons in other parts of the codebase, those seem to prefer g_ascii_strcasecmp which is going to be less accurate than this one.
|
|
||
| ignore_check_plus(server, nick, address, channel, invited, &level, FALSE); | ||
|
|
||
| str = show_lowascii(channel); |
There was a problem hiding this comment.
TIL about this function! Seems like the point is to prevent people from introducing color codes in channel names to trick others into joining channels they don't actually trust, which makes sense for incoming invites for you.
For invites to other people in channels you already are part of, it doesn't make as much sense.
But harmless, so I don't mind if you keep it this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.