Skip to content

sending of tag messages and customisable maximum irc message length #1092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 26, 2019

Conversation

ailin-nemui
Copy link
Contributor

No description provided.

@ailin-nemui ailin-nemui force-pushed the outgoing-tags branch 3 times, most recently from b332d0d to 645357e Compare August 13, 2019 16:31
@dequis
Copy link
Member

dequis commented Aug 14, 2019

I like what I see!

So this adds CAP_MESSAGE_TAGS to the .h file but doesn't request it, is that intended?

@ailin-nemui
Copy link
Contributor Author

it is, we use it to ensure if a server understands /expects tags as input, but we don't necessarily need to request tags going in our direction

that said we're probably going to request it in a future PR (soon)

@dequis
Copy link
Member

dequis commented Aug 14, 2019

I guess it's easily testable with /quote cap req message-tags

@ailin-nemui
Copy link
Contributor Author

should be!

@ailin-nemui
Copy link
Contributor Author

thanks for review!

@ailin-nemui ailin-nemui force-pushed the outgoing-tags branch 2 times, most recently from 6a0bab1 to bf79685 Compare August 15, 2019 11:27
@ailin-nemui
Copy link
Contributor Author

@dequis can this be merged?

@ailin-nemui
Copy link
Contributor Author

@irssi/developers

Copy link
Member

@dequis dequis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ailin-nemui ailin-nemui merged commit 3f0afa9 into irssi:master Aug 26, 2019
@ailin-nemui
Copy link
Contributor Author

nice!

@ailin-nemui ailin-nemui deleted the outgoing-tags branch August 26, 2019 20:02
@ailin-nemui ailin-nemui added this to the 1.3.0 milestone Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants