-
Notifications
You must be signed in to change notification settings - Fork 371
sending of tag messages and customisable maximum irc message length #1092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
b332d0d
to
645357e
Compare
I like what I see! So this adds CAP_MESSAGE_TAGS to the .h file but doesn't request it, is that intended? |
it is, we use it to ensure if a server understands /expects tags as input, but we don't necessarily need to request tags going in our direction that said we're probably going to request it in a future PR (soon) |
I guess it's easily testable with |
should be! |
645357e
to
33b53f6
Compare
thanks for review! |
6a0bab1
to
bf79685
Compare
bf79685
to
6c37099
Compare
@dequis can this be merged? |
@irssi/developers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
nice! |
No description provided.