Skip to content

enable irc cap ls 302 #1091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 13, 2019
Merged

enable irc cap ls 302 #1091

merged 2 commits into from
Aug 13, 2019

Conversation

ailin-nemui
Copy link
Contributor

@ailin-nemui ailin-nemui commented Aug 13, 2019 •
edited
Loading

this is needed to learn about the values of capabilities, otherwise
they are not sent for backwards compatibility reasons

the values are required to support for example the maximum line length
value (upcoming patch)

also change the strings to #defines for easier handling

@dequis
Copy link
Member

dequis commented Aug 13, 2019

also change the strings to #defines for easier handling

Easier how? Locality is underrated imo

@ailin-nemui
Copy link
Contributor Author

we may need to refer to those caps in further hash table lookups

dequis
dequis approved these changes Aug 13, 2019
View reviewed changes
Copy link
Member

@dequis dequis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair enough!

@ailin-nemui ailin-nemui merged commit 3ea22fb into irssi:master Aug 13, 2019
@ailin-nemui ailin-nemui deleted the cap302 branch August 14, 2019 08:40
@ailin-nemui ailin-nemui added this to the 1.3.0 milestone Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dequis dequis dequis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ailin-nemui @dequis