Use the 24bit mIRC colour mappings if colors_ansi_24bit is enabled #1059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR was sponsored by |
|
@irssi/developers |
|
This uses mod 100, meaning possible indices are 0-99; however, neither mirc_colors nor mirc_colors24 are long enough to have index 99. |
|
I would hope it does... hopefully only the comment is misleading |
|
I failed at the math; indeed, only the comments are wrong (first line of both has 16, the 7 subsequent lines have 12 each; 16 + 7 * 12 = 100) |
dwfreed
approved these changes
Jun 27, 2019
ailin-nemui
added a commit
that referenced
this pull request
Apr 8, 2021
Use the 24bit mIRC colour mappings if colors_ansi_24bit is enabled (cherry picked from commit d34bd85)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this also fixed mIRC colours when colors_ansi_24bit is not enabled