Skip to content

new scrollback_format code breaks "print text" modifiers #1189

@ailin-nemui

Description

@ailin-nemui

Let me explain what I designed in #1079 and how it breaks now...

for example colorize_nicks.pl stops working :-(

Some modules will hook "print text" and alter the printed text.

The print text is the final parsed text that Irssi prints, after expanding

  1. themes,
  2. formats,
  3. expandos and
  4. arguments.

I changed the code to skip this step and instead store the arguments and formats. That way the formats can be changed and the rendering process can be repeated. This is required in order to support some dynamic features such as

  • showing server side time
  • showing account tag marker
  • changing the column width for the nick column also of old text
  • changing the themeing of old text
  • refreshing the nick colours (once we have the patch with variable-expandos)

Now what can be done?

I could emit the print text on rendering. That might work for some scripts, but it would confuse other scripts for example the hilightwin or any notification script would create new hilight entries each time you scroll through your buffer!

...or somehow try to hook the print text and find out if there were any modifications and then try to map that back to the arguments -- which seems impossible to me but idk?

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions