cleanup IPython handler settings #3088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have skimmed over this and it looks good. Let's wait until #3011 is merged, check for rebase and the I will do a final review pass. |
move settings to the tornado settings dict, rather than a mixture of tornado settings and application references, and application.ipython_app references. removes any reference to application / ipython_app attributes in the handlers, in favor of the tornado settings dict. These were a massive pain for anyone who might want to re-use our handlers.
| self.read_only = self.ipython_app.read_only | ||
| self.config = self.ipython_app.config | ||
| self.use_less = self.ipython_app.use_less | ||
| self.log = log |
There was a problem hiding this comment.
Looks like log didn't make it into settings. Do you think we don't need it?
There was a problem hiding this comment.
Well, we never have used it in the handlers. Tornado has its own logging mechanisms, and tornado handlers should probably use them. If anything, the main app should hook up tornado's logging to our app's logging.
|
This looks great, merging. |
as a no-op
use IPython logger as first choice, fall back on tornado logger (for use in non-IPython apps).
ellisonbg
added a commit
that referenced
this pull request
Apr 25, 2013
cleanup IPython handler settings
mattvonrocketstein
pushed a commit
to mattvonrocketstein/ipython
that referenced
this pull request
Nov 3, 2014
cleanup IPython handler settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move any settings / shared objects to the tornado settings dict, rather than a mixture of tornado settings and application references, and application.ipython_app references.
Removes any reference to application / ipython_app attributes in the handlers, in favor of the tornado settings dict. These were a massive pain for anyone who might want to re-use our handlers.
This depends on PR #3011, it is actually just one commit (at this point).