fix: use autonatv2 event to begin cert management #70
Conversation
This also ignores any unreachable TCP addresses that are prefixes of the websocket addresses.
There was a problem hiding this comment.
tested locally (ipv4-only) with ipfs/kubo#10835 and against https://github.com/libp2p/go-libp2p/tree/master/examples/autotls and lgtm, but waiting with merge & release until:
- CI in ipfs/kubo#10835 is green
| // if the tcp component is unreachable, ignore the ws addr too | ||
| if ua.Equal(withoutForgeWSS) { | ||
| continue | ||
| } |
There was a problem hiding this comment.
thx, iiuc this should help with #25 too
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #70 +/- ##
==========================================
+ Coverage 60.28% 61.68% +1.40%
==========================================
Files 11 11
Lines 1035 1219 +184
==========================================
+ Hits 624 752 +128
- Misses 343 394 +51
- Partials 68 73 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
CI in ipfs/kubo#10835 is green, manual tests also seem to work for me (at least ipv4 only setup seems to wait if no reachable addrs).
I'm going to merge this and use the commit from the main branch in Kubo 0.36 RC1.
If no issues, and once we have a final go-libp2p 0.42 i'll switch to that, and then tag a release of p2p-forge (we don't want to release without stable go-libp2p dependency)
* update autotls; libp2p to use autonatv2 * chore: p2p-forge@main with autonat fix ipshipyard/p2p-forge#70 --------- Co-authored-by: Marcin Rataj <lidel@lidel.org>
This also ignores any unreachable TCP addresses that are prefixes of the websocket addresses.