Skip to content

Conversation

lidel
Copy link
Member

@lidel lidel commented Aug 13, 2025

This PR adds AutoConf support to Rainbow.

@lidel lidel requested review from hsanjuan and gammazero August 13, 2025 10:30
@lidel lidel changed the title feat: autoconf support feat(config): AutoConf with "auto" placeholders Aug 13, 2025
@lidel lidel marked this pull request as ready for review August 13, 2025 10:45
Copy link
Contributor

@gammazero gammazero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only trivial comments, otherwise good to merge.

Copy link
Contributor

@gammazero gammazero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment regarding pebble.

lidel added 3 commits August 19, 2025 22:25
instead of silently stripping 'auto' values, now returns clear error
messages indicating which config options need explicit values
- merge autoconf_routing_test.go into autoconf_test.go
- add meaningful error messages to assertions
- organize with subtests using t.Run()
@lidel
Copy link
Member Author

lidel commented Aug 19, 2025

@hsanjuan applied changes discussed during triage today:

  • running with --autoconf=false on its own will now refuse to start and produce an error urging user to explicitly set --bootstrap etc.

take a look, if looks ok, feel free to merge

@hsanjuan
Copy link
Contributor

I have just moved the autoconf options to the top, as they are somehow "general" and affect how options below behave. LGTM otherwise.

@hsanjuan hsanjuan enabled auto-merge August 20, 2025 10:29
@hsanjuan hsanjuan merged commit 59e4f76 into main Aug 20, 2025
10 checks passed
@hsanjuan hsanjuan deleted the feat-mainnet-autoconfig branch August 20, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants