-
Notifications
You must be signed in to change notification settings - Fork 20
feat(config): AutoConf with "auto" placeholders #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
depends on ipfs/boxo#997
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only trivial comments, otherwise good to merge.
align with boxo gateway default value
- reverts automatic dependency upgrade to keep PR focused - updates boxo to latest main with autoconf support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One comment regarding pebble.
instead of silently stripping 'auto' values, now returns clear error messages indicating which config options need explicit values
- merge autoconf_routing_test.go into autoconf_test.go - add meaningful error messages to assertions - organize with subtests using t.Run()
@hsanjuan applied changes discussed during triage today:
take a look, if looks ok, feel free to merge |
I have just moved the |
This PR adds AutoConf support to Rainbow.