Skip to content

fix: empty env variable setting an empty allowlist #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 26, 2025
Merged

fix: empty env variable setting an empty allowlist #269

merged 1 commit into from
Jun 26, 2025

Conversation

hsanjuan
Copy link
Contributor

No description provided.

@hsanjuan hsanjuan self-assigned this Jun 25, 2025
@hsanjuan hsanjuan requested a review from gammazero June 25, 2025 12:52
@lidel lidel changed the title Fix empty env variable setting an empty allowlist fix: empty env variable setting an empty allowlist Jun 25, 2025
@lidel lidel mentioned this pull request Jun 25, 2025
Merged
2 tasks
lidel
lidel reviewed Jun 26, 2025
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but this feels like a footgun big enough, that we should special-case empty string in boxo, and interpret it as nil as well.

@hsanjuan hsanjuan merged commit f2e93c1 into main Jun 26, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

@gammazero gammazero Awaiting requested review from gammazero

Assignees

@hsanjuan hsanjuan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hsanjuan @lidel