Skip to content

fix: set User-Agent for HTTP retrieval client #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

lidel
Copy link
Member

@lidel lidel commented Apr 25, 2025

Setting to the same value we already use for libp2p:

libp2p.UserAgent("rainbow/"+buildVersion()),

This makes is easier to track which specific rainbow build/release is responsible for requests.
We need this, because Kubo and Rainbow may use the same boxo, but initialize client with slightly different config (Ref. ipfs/kubo#10772)

makes is easier to track which specific rainbow build/release
is responsible for requests.

we need this, because Kubo and Rainbow may use the same boxo, but
initialize client with slightly different config

Ref. ipfs/kubo#10772
@lidel lidel requested a review from hsanjuan April 25, 2025 17:35
@lidel lidel requested a review from gammazero April 25, 2025 19:36
@guillaumemichel guillaumemichel merged commit 0e505f1 into main Apr 29, 2025
8 of 9 checks passed
@guillaumemichel guillaumemichel deleted the fix/user-agent-http-retrieval branch April 29, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants