Skip to content

feat: rename Delegated Routing HTTP API to Routing v1 HTTP API #387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 30, 2023
Merged

feat: rename Delegated Routing HTTP API to Routing v1 HTTP API #387

merged 2 commits into from
Mar 30, 2023

Conversation

aschmahmann
Copy link
Contributor

@guseggert @lidel this was the name requested for API (and partial resolution of ipfs/kubo#9479).

Any issues/suggestions here?

@aschmahmann aschmahmann force-pushed the feat/rename-delegated-routing branch from 3325b19 to 2fa485f Compare March 20, 2023 16:20
@aschmahmann aschmahmann force-pushed the feat/rename-delegated-routing branch from 2fa485f to 7435f5f Compare March 20, 2023 16:22
lidel
lidel approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@lidel lidel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we've been already referring to this as /routing/v1

@aschmahmann aschmahmann merged commit 74711ac into main Mar 30, 2023
@aschmahmann aschmahmann deleted the feat/rename-delegated-routing branch March 30, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

@guseggert guseggert guseggert approved these changes

Assignees

@aschmahmann aschmahmann

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aschmahmann @lidel @guseggert