fix: allow injection of trustless config #791
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
fix: allow injection of trustless config
Description
Allows injection of config that is considered untrusted, but only overrides settings that are allowed to be overridden.
We do not allow injection of URLs if the config is considered untrusted.
See discussion at ipfs/helia#824 for more details
Notes & open questions
This PR also removes the dependency on lz-string, reducing initial javascript loaded by about 10kb, but increases size of the
ipfs-sw-cfg
content by about 200 bytes. This should result in a net reduction in bandwidth usage.Change checklist