docs: cleanup configuration UI #744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this moves Routing to the top, and adds more details to descriptions and labels
2color
reviewed
Jun 10, 2025
src/pages/config.tsx
Outdated
| /> | ||
| <TextInput | ||
| className='e2e-config-page-input e2e-config-page-input-dnsJsonResolvers' | ||
| description='A newline delimited list of space delimited key+value pairs for DNS (application/dns-json) resolvers. The key is the domain suffix, and the value is the URL of the DNS resolver. Note: Use only trusted centralized gateways, as they may infer your browsing history.' |
There was a problem hiding this comment.
Is this note meant for the Recursive Gateways input?
Suggested change
| description='A newline delimited list of space delimited key+value pairs for DNS (application/dns-json) resolvers. The key is the domain suffix, and the value is the URL of the DNS resolver. Note: Use only trusted centralized gateways, as they may infer your browsing history.' | |
| description='A newline delimited list of space delimited key+value pairs for DNS (application/dns-json) resolvers. The key is the domain suffix, and the value is the URL of the DNS resolver.' |
There was a problem hiding this comment.
I think a note here that tracking may be done by the gateways you use is important. Do we want to remove it fully or can we rephrase it?
There was a problem hiding this comment.
My bad. This type of note applies to every remote endpoint defined in config, seems I messed up adding it everywhere.
Fixed in 6864d0b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
cc:
Change checklist