Skip to content

Skip unactionable providers in check #70

@2color

Description

@2color

Problems

  • With feat: add ipni checks #66, we now get providers from the IPNI, however the Check backend only supports probing peers that support Bitswap, since both transport-graphsync-filecoinv1 and transport-ipfs-gateway-http are unsupported by both Boxo, Kubo and Rainbow.
  • The IPNI sometimes return duplicate providers (see screenhot)
  • Since we limit the number of providers we test to 10, we often end up in a situation where we get multiple unactionable providers from the IPNI and don't test any providers from the DHT (because it's usually slower to respond) and the loop exits once the max has reached, irrespective of the source of providers.

Screenshot 2024-09-27 at 1 00 16 PM

Example

Potential solutions

  • limit the number of providers from each source (DHT/IPNI) so that we always try to get providers from both
  • Skip providers that only transport-graphsync-filecoinv1 and [transport-ipfs-gateway-http]
  • Deduplicate providers from the IPNI so that we only test distinct PeerIDs once

Metadata

Metadata

Assignees

No one assigned

    Labels

    P1High: Likely tackled by core team if no one steps updif/mediumPrior experience is likely helpfuleffort/daysEstimated to take multiple days, but less than a week

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions