-
Notifications
You must be signed in to change notification settings - Fork 16
Closed
Labels
P1High: Likely tackled by core team if no one steps upHigh: Likely tackled by core team if no one steps updif/mediumPrior experience is likely helpfulPrior experience is likely helpfuleffort/daysEstimated to take multiple days, but less than a weekEstimated to take multiple days, but less than a week
Description
Problems
- With feat: add ipni checks #66, we now get providers from the IPNI, however the Check backend only supports probing peers that support
Bitswap
, since bothtransport-graphsync-filecoinv1
andtransport-ipfs-gateway-http
are unsupported by both Boxo, Kubo and Rainbow. - The IPNI sometimes return duplicate providers (see screenhot)
- Since we limit the number of providers we test to 10, we often end up in a situation where we get multiple unactionable providers from the IPNI and don't test any providers from the DHT (because it's usually slower to respond) and the loop exits once the max has reached, irrespective of the source of providers.
Potential solutions
- limit the number of providers from each source (DHT/IPNI) so that we always try to get providers from both
- Skip providers that only
transport-graphsync-filecoinv1
and [transport-ipfs-gateway-http
] - Deduplicate providers from the IPNI so that we only test distinct PeerIDs once
Metadata
Metadata
Assignees
Labels
P1High: Likely tackled by core team if no one steps upHigh: Likely tackled by core team if no one steps updif/mediumPrior experience is likely helpfulPrior experience is likely helpfuleffort/daysEstimated to take multiple days, but less than a weekEstimated to take multiple days, but less than a week