feat: expose providers option #834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows pre-seeding transfer sessions with known providers if they are available.
SgtPooki
reviewed
Jul 24, 2025
| import type { FileCandidate } from 'ipfs-unixfs-importer' | ||
| import type { KuboInfo, KuboNode } from 'ipfsd-ctl' | ||
|
|
||
| describe('providers', () => { |
There was a problem hiding this comment.
Are we validating that the Kubo node is providing the content, or at least that it is getting a request from us?
It doesn't look like we're overriding gateways, routers, nor bootstrap config in fixtures/create-helia so some of these could be succeeding against the network, right?
|
I've asserted that the blocks are being provided by the kubo node, and added a test that shows that retrieval fails without specifying providers (since the Helia node has no peer discovery mechanism configured). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows pre-seeding transfer sessions with known providers if they are available.
Change checklist