-
Notifications
You must be signed in to change notification settings - Fork 133
fix: flaky test to publish an IPNS record #810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, nice concise fix. fantastic. Thank you for the contribution! just going to let the CI run and if it's good i'll merge it.
@Haxry looks like there are some lint errors, can you make sure you fix those? |
@SgtPooki the lint error states that it cant read tsconfig.json from helia/tsconfig.json , but that file dosent exist at first place. I have not changed anything there. I just made changes to the publish.spec.ts file Should i add a tsconfig.json at the root ? |
No, all you need to do is run |
* origin/main: (27 commits) fix: flaky test to publish an IPNS record (#810) docs: fix API docs link (#809) fix: trustless gateway returned blocks can be limited (#791) deps: bump kubo from 0.34.1 to 0.35.0 in the kubo-deps group (#806) chore: fix linting chore: release main (#805) chore: bump execa from 8.0.1 to 9.5.3 (#797) chore: bump @helia/unixfs from 4.0.3 to 5.0.2 in /benchmarks/add-dir (#796) chore: bump codecov/codecov-action from 5.4.0 to 5.4.3 (#802) chore: bump tinybench from 3.1.1 to 4.0.1 (#798) deps: update aegir to 47.x.x (#804) chore: dep groups again chore: restore groups chore: remove groups chore: release main (#793) deps: update all deps (#792) chore: release main (#774) feat: pass initial providers to session (#777) ci: uci/copy-templates (#782) fix: propagate ipns failures (#789) ...
Title
closes #785
Description
Notes & open questions
Change checklist