Skip to content

fix: flaky test to publish an IPNS record #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2025
Merged

Conversation

Haxry
Copy link
Contributor

@Haxry Haxry commented Jun 3, 2025

Title

closes #785

Description

Notes & open questions

Change checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation if necessary (this includes comments as well)
  • I have added tests that prove my fix is effective or that my feature works

@Haxry Haxry changed the title fix: flaky test - should publish an IPNS record with a custom lifetime params fix: flaky test to publish an IPNS record Jun 3, 2025
@Haxry Haxry marked this pull request as ready for review June 3, 2025 08:42
@Haxry Haxry requested a review from a team as a code owner June 3, 2025 08:42
@Haxry
Copy link
Contributor Author

Haxry commented Jun 3, 2025

@2color @SgtPooki plz review

Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice concise fix. fantastic. Thank you for the contribution! just going to let the CI run and if it's good i'll merge it.

@SgtPooki
Copy link
Member

SgtPooki commented Jun 3, 2025

@Haxry looks like there are some lint errors, can you make sure you fix those?

@Haxry
Copy link
Contributor Author

Haxry commented Jun 3, 2025

@SgtPooki the lint error states that it cant read tsconfig.json from helia/tsconfig.json , but that file dosent exist at first place. I have not changed anything there. I just made changes to the publish.spec.ts file

Should i add a tsconfig.json at the root ?

image

@achingbrain
Copy link
Member

Should i add a tsconfig.json at the root ?

No, all you need to do is run npm run lint -- -- --fix from the root of the repo, or npm run lint -- --fix in the individual modules with linting errors.

@Haxry
Copy link
Contributor Author

Haxry commented Jun 4, 2025

@SgtPooki @2color plz review

@SgtPooki SgtPooki merged commit 28a7091 into ipfs:main Jun 5, 2025
30 of 31 checks passed
@achingbrain achingbrain mentioned this pull request Jun 2, 2025
2color added a commit that referenced this pull request Jun 18, 2025
* origin/main: (27 commits)
  fix: flaky test to publish an IPNS record  (#810)
  docs: fix API docs link (#809)
  fix: trustless gateway returned blocks can be limited (#791)
  deps: bump kubo from 0.34.1 to 0.35.0 in the kubo-deps group (#806)
  chore: fix linting
  chore: release main (#805)
  chore: bump execa from 8.0.1 to 9.5.3 (#797)
  chore: bump @helia/unixfs from 4.0.3 to 5.0.2 in /benchmarks/add-dir (#796)
  chore: bump codecov/codecov-action from 5.4.0 to 5.4.3 (#802)
  chore: bump tinybench from 3.1.1 to 4.0.1 (#798)
  deps: update aegir to 47.x.x (#804)
  chore: dep groups again
  chore: restore groups
  chore: remove groups
  chore: release main (#793)
  deps: update all deps (#792)
  chore: release main (#774)
  feat: pass initial providers to session (#777)
  ci: uci/copy-templates (#782)
  fix: propagate ipns failures (#789)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: flaky test - should publish an IPNS record with a custom lifetime params
4 participants